Skip to content

[HttpFoundation] 14114 header option 'X-Forwarded-Prefix' #15910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

JohJohan
Copy link
Contributor

Fixes #14114.

Should i also document something about using it with traefik? @jeff1985 you might be able to anwser that as you added the code with symfony/symfony#37734

Could a label hacktoberfest-accepted be added to this pull request? I am participating https://hacktoberfest.digitalocean.com/details

@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 4.4, 5.3, 5.4, 6.0.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 5.2 milestone Oct 10, 2021
@carsonbot carsonbot changed the title 14114 [HttpFoundation] header option 'X-Forwarded-Prefix' [HttpFoundation] 14114 header option 'X-Forwarded-Prefix' Oct 10, 2021
@javiereguiluz
Copy link
Member

Thanks @JohJohan! About the label ... we already have hacktoberfest as a topic of this repository so, if I'm right, merging this PR will give you the needed attribution without having to add the label too.

@JohJohan
Copy link
Contributor Author

@javiereguiluz i think you are right thanks!

@javiereguiluz javiereguiluz changed the base branch from 5.2 to 5.3 October 14, 2021 15:13
@javiereguiluz
Copy link
Member

Thank you Johan.

@javiereguiluz javiereguiluz merged commit 31be485 into symfony:5.3 Oct 14, 2021
@JohJohan JohJohan deleted the 14114 branch October 14, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants